[docs] fix broken links #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonge97
approved these changes
Jun 28, 2023
|
@wonge97 Is there anything I should do about these failed CI tests? Are they really failing just from updating the docs? |
|
hey @Abyiss-Zach , sorry for late reply frokm me - I don't think there's anything to do about the failed CI tests, wouldn't be related to the doc updates here. |
|
@wonge97 No worries at all. Now since these CI tests have failed, I am unable to merge this PR in. It also appears that I am unable to rerun any of these workflows. Is there a procedure somewhere or something that I should perform to get this PR merged? |
duncancmt
approved these changes
Jul 11, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was reading through the 0x docs and noticed a broken link, so this PR fixes the broken link to the proxy page from the feature page.
I have not included any tests or changelog updates for this PR. Please let me know if/where I should add any of these.
Testing instructions
To my knowledge, not much testing can be done until the updated version of these docs are deployed. However since
governor.rstandproxy.rstare in the same directory, you can see that the relative path forproxyis now identical to the relative path forgovernorin this screenshot:Types of changes
Checklist: