Base mainnet #734
Merged
Base mainnet #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavDont
approved these changes
Jul 17, 2023
dekz
approved these changes
Jul 17, 2023
|
Have we considered not adding base goerli? I slightly prefer not adding base goerli unless we are going to use it or maintain it (there is some minor downstream effect once base goerli is added to ChainId). |
|
I don't anticipate putting effort into maintaining the Base Goerli deployment, especially since it's in a marginally different state from the Base Mainnet deployment. I'm inclined to defer to @kyu-c since he would be the one whom this decision affects |
|
@duncancmt let's remove it for now (and only add if we end up needing it). |
kyu-c
approved these changes
Jul 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bridge adapters for Base and Base testnet (Goerli)
Checklist: