Skip to content

Add UniswapV3 to Avalanche and BSC bridge adapters #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add UniswapV3 to Avalanche and BSC bridge adapters #735

merged 2 commits into from
Jul 19, 2023

Conversation

kyu-c
Copy link
Contributor

@kyu-c kyu-c commented Jul 17, 2023 •
edited
Loading

Description

  • Fixes LIT-1176
  • Add Uniswap V3 to Avalanche and BSC bridge adapters
  • Add router v2 support in MixinUniswapV3 (backward compatible)
    • This change is needed as newer Uniswap V3 deployments do not have router v1 (e.g. BSC, Avalanche).
  • Update Avalanche/BSC FillQuoteTransformer addresses

Testing instructions

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kyu-c kyu-c requested a review from dekz as a code owner July 17, 2023 20:48
@kyu-c kyu-c changed the title Add UniswapV3 to Avalanche and BSC Add UniswapV3 to Avalanche and BSC bridge adapters Jul 17, 2023
@kyu-c kyu-c force-pushed the kyu/uni-v3-avax-bsc branch from 0adc17b to 4e297b2 Compare July 17, 2023 20:56
@kyu-c kyu-c requested review from SavDont and duncancmt July 17, 2023 20:56
@kyu-c
Add UniswapV3 to Avalanche and BSC
ec25d88 
 * Support v2 router in MixinUniswapV3
@kyu-c kyu-c force-pushed the kyu/uni-v3-avax-bsc branch from 4e297b2 to ec25d88 Compare July 18, 2023 23:42
@kyu-c kyu-c requested a review from SavDont July 19, 2023 03:57
@SavDont SavDont merged commit 4835a1b into development Jul 19, 2023
@SavDont SavDont deleted the kyu/uni-v3-avax-bsc branch July 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavDont SavDont SavDont approved these changes

@dekz dekz Awaiting requested review from dekz dekz is a code owner

@duncancmt duncancmt Awaiting requested review from duncancmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyu-c @SavDont