Skip to content

Adding support for Velodrome V2 on Optimism #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

SavDont
Copy link
Contributor

@SavDont SavDont commented Aug 2, 2023

Description

Closes LIT-1177
Adding Velodrome V2 Mixin and adding the Mixin to Optimism Bridge Adapter.

Testing instructions

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@SavDont SavDont requested a review from dekz as a code owner August 2, 2023 15:35
@SavDont SavDont requested a review from kyu-c August 2, 2023 15:36
Copy link
Contributor

@kyu-c kyu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There should be also corresponding protocol-utils change (either this PR or as a follow-up).

https://github.com/0xProject/protocol/blob/development/packages/protocol-utils/src/transformer_utils.ts#L168

@SavDont SavDont merged commit 43e3dce into development Aug 8, 2023
@SavDont SavDont deleted the feat/AddVelodromeV2ToOptimism branch August 8, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants