Skip to content

fix(docs): remove devUtils blocking docs generation #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

igorline
Copy link

Description

Docs generation was blocked due to error occurring as devUtils were removed from addresses.json in d738eed

Traceback (most recent call last):
  File "0xprotocol/docs/scripts/generate_addresses.py", line 108, in <module>
    printTable(section["contracts"], addresses["1"], "1")
  File "0xprotocol/docs/scripts/generate_addresses.py", line 84, in printTable
    if isinstance(addresses[contract], str):
                  ~~~~~~~~~^^^^^^^^^^
KeyError: 'devUtils'

Contract addresses located at https://docs.0xprotocol.org/en/latest/index.html hasn't been updated since then

Testing instructions

Follow instructions to generate docs in the docs folder

Types of changes

Removed deprecated contract addresses and auto-generated new addresses for the docs

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 13, 2023
@github-actions github-actions bot closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant