chore: refactored to reduce repetition #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fearphage is attempting to deploy a commit to the 9d8 Team on Vercel. A member of the Team first needs to authorize it. |
fearphage
commented
Aug 25, 2024
| const response = await fetch(url); | ||
| const posts: Post[] = await response.json(); | ||
| return posts; | ||
| return wpFetch<Post[]>("/wp-json/wp/v2/posts", { author: filterParams?.author, tags: filterParams?.tag, categories: filterParams?.category }); |
There was a problem hiding this comment.
I'm not very familiar with WordPress, but if the /wp-json/wp/v2/ part of the path is constant, that could also be moved into the wpFetch wrapper. Repeating it doesn't really seem to be serving any purpose.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
opting to keep as is on this one. I like the abstraction in theory but I think for people coming into the codebase, seeing the explicitness behind each API call makes it easier to read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is building on top of the
getUrlextraction. All the code is doing relatively the same thing so I refactored it all into awpFetchwrapper aroundfetch. This drastically reduces the repetitiveness of the code as well as enables a central location to insert error handling, request tracing, etc.PS. I'm relatively sure the the explicit return types of
Promise<Post>for instance aren't needed anymore with this implementation, but I kept them there to confirm the contract is maintained since I couldn't find any tests to update.