Fix error in post page when no featured image is set #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lacruzwebdev is attempting to deploy a commit to the 9d8 Team on Vercel. A member of the Team first needs to authorize it. |
|
It's probably a good idea to include this bit of logic inside getFeaturedMediaById? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brijr
approved these changes
Jan 28, 2025
|
This looks great, thanks for catching @lacruzwebdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing a post page without a featured image set, we're getting the following error:
WP Rest API returns a 0 whenever there's no featured image set, so we need to make sure that post.featured_media is not falsy before invoking getFeaturedMediaById because there's no media with an id of 0, hence the error.