Add function to build the url for each request #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alonsourena is attempting to deploy a commit to the 9d8 Team on Vercel. A member of the Team first needs to authorize it. |
youngbloodcyb
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
lgtm - i really like this approach and i think it cleans it up a ton
@brijr wanna take a quick peak before we merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
getUrlfunction to build the url in an easy and reusable way.I take the inspiration from the medusajs repo.
Here's the file where this function is located on the medusajs repo
https://github.com/medusajs/medusa/blob/develop/packages/admin-next/dashboard/src/lib/client/common.ts