Skip to content

fix: resetting page param on filter change #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

islamBelabbes
Copy link
Contributor

@islamBelabbes islamBelabbes commented May 5, 2025

This PR addresses the issue where the selected pagination page persists after applying a new filter (as reported in #35). The fix ensures that when filters are changed, the page query parameter is removed,

Summary by CodeRabbit

  • Bug Fixes
    • Changing filters now always resets pagination, ensuring the page number is cleared whenever a new filter is applied.

Copy link

vercel bot commented May 5, 2025

@islamBelabbes is attempting to deploy a commit to the 9d8 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented May 5, 2025

Walkthrough

The handleFilterChange function in the posts filter component was updated to always remove the "page" query parameter from the URL before applying a new filter. This ensures that changing filters resets pagination, regardless of the selected filter value.

Changes

File(s) Change Summary
components/posts/filter.tsx Modified handleFilterChange to always delete the "page" parameter from the URL before filtering.

Poem

A filter clicked, the page resets,
No lingering numbers, no old regrets.
With every hop, the posts renew,
Fresh results for every view.
A bunny’s joy in tidy code—
Onward, forward, down the road! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/posts/filter.tsx

Oops! Something went wrong! :(

ESLint: 9.26.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b1c127 and 3ff428c.

📒 Files selected for processing (1)
  • components/posts/filter.tsx (1 hunks)
🔇 Additional comments (1)
components/posts/filter.tsx (1)

50-52: Great fix for the pagination reset issue!

This change addresses issue #35 perfectly by ensuring that any filter change resets the pagination. The implementation is clean and concise:

  1. Unconditionally removing the "page" parameter ensures users always start at the first page after changing filters
  2. Using a ternary operator makes the code more readable than an if/else statement

This will prevent the confusing UX situation where a user might land on an empty page after changing filters while on a later page.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@brijr brijr self-requested a review May 6, 2025 06:20
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-wp ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 6:22am

@brijr brijr merged commit 21014e2 into 9d8dev:main May 6, 2025
3 checks passed
@islamBelabbes islamBelabbes deleted the reset-page-no-filter-change branch May 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants