Add option to enable data checksums (postgresql_data_checksums) #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Except I would recommend to use Ansible official function for comparison versions. |
UnderGreen
approved these changes
Mar 2, 2018
The option is turned on by default, whih is a best practice because it safeguards data integrity at a minimal performance cost. "Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent. Enabling checksums may incur a noticeable performance penalty. This option can only be set during initialization, and cannot be changed later. If set, checksums are calculated for all objects, in all databases."
Author
|
Changed it to use the |
gclough
pushed a commit
to gclough/postgresql
that referenced
this pull request
Mar 5, 2018
Blatantly merged in code from ANXS#246, as suggested by @UnderGreen , and coded by @blubber . I hope this isn't seen negatively, as I'm trying to expand the code to cover all initdb options. I'd be just as happy if you want to take my code, and merge it into ANXS#246.
Author
|
Superseded by #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is turned on by default, whih is a best practice because it safeguards data integrity at a minimal performance cost.
"Use checksums on data pages to help detect corruption by the I/O system that would otherwise be silent. Enabling checksums may incur a noticeable performance penalty. This option can only be set during initialization, and cannot be changed later. If set, checksums are calculated for all objects, in all databases."
Edit: seems this is just for RedHat, don't know how initdb get's executed on Debian derivatives.