Skip to content

Conversation

@lrk
Copy link
Contributor

@lrk lrk commented Jan 20, 2020

My proposal to fix issue #464

I renamed all role internal vars with double underscore prefix, and set values in defaults/main.yml.
I also remove unnecessary version specific files as they all contain same values that is now set as default.

I didn't come with an elegant solution for default postgis dependencies so i create the postgresql_ext_postgis_default_deps list that is used when __postgresql_ext_postgis_deps will be undefined.

side note: i think that comment with ">= version number" are incorrect, they should be "<= version number" in most cases as i think it should be read as: "when current version <= version number ..."
(example: the postgresql_jit variable comment)

I had to set login_unix_socket and --host parameters to tasks connecting to server for admin purposes to fix connection errors too

@lrk lrk requested a review from gclough January 20, 2020 14:33
@lrk lrk marked this pull request as ready for review January 21, 2020 08:46
@lrk
Copy link
Contributor Author

lrk commented Jan 21, 2020

It seem the build fail for ubuntu / debian, i'll check that tonight.

Add login_unix_socket and --host parameters to tasks connecting to server for admin purposes to fix connection errors
@gclough
Copy link
Collaborator

gclough commented Mar 6, 2020

Hi @lrk , there is some good stuff in here, thanks. As the build is failing, and to make it easier to review. Would it be possible to break them down into a couple of PR's?

@lrk
Copy link
Contributor Author

lrk commented Mar 6, 2020

@gclough sure, all i need is some time to re-work on that.

I did some other modification in my fork project for which i have to create PR here.

@thbar
Copy link
Contributor

thbar commented Aug 24, 2020

I would love to see some progress on this one. I believe #464 is the most problematic part of this role right now, because it makes it hard to override bogus defaults, such as #489 or similar (if I understand the problem correctly!).

Happy to help out a bit here (testing etc), at least on Ubuntu 16/18/20.

@lrk lrk closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants