Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal to fix issue #464
I renamed all role internal
varswith double underscore prefix, and set values indefaults/main.yml.I also remove unnecessary version specific files as they all contain same values that is now set as default.
I didn't come with an elegant solution for default postgis dependencies so i create the
postgresql_ext_postgis_default_depslist that is used when__postgresql_ext_postgis_depswill be undefined.side note: i think that comment with ">= version number" are incorrect, they should be "<= version number" in most cases as i think it should be read as: "when current version <= version number ..."
(example: the
postgresql_jitvariable comment)I had to set
login_unix_socketand--hostparameters to tasks connecting to server for admin purposes to fix connection errors too