Skip to content

Conversation

@storeman
Copy link

No description provided.

@soupdiver
Copy link
Contributor

It would be better to put different things into different PRs.
Commit 2 and 3 are not related to the PR title.

storeman@3c59994 looks good for me but needs an update of the README or defaults/main.yml

storeman@6f40e83 looks good but also needs an update of the README or defaults/main.yml

storeman@d784a60 I'm not sure about that one. This can already be achieved by the current handling of privileges.

@otakup0pe @pjan @farridav any opinions on that from your side?

@otakup0pe
Copy link
Member

Definitely need to update the README if we are adding/changing variables.

@storeman
Copy link
Author

storeman commented Aug 2, 2015

I'll make new PRs.

@storeman storeman closed this Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants