Skip to content

Conversation

@Ackar
Copy link

@Ackar Ackar commented Nov 18, 2020

Add support for an @override directive as mentionned in #17 (comment)

This works by finding all the fields with an @override directive in the extension schema and removing them from the source schema.

@hotsezus
Copy link

hotsezus commented Dec 26, 2020

This PR solves new directive problem but i'm not sure if editor works properly when extending remote type and overriding some field. We need to be sure editor will not output that local field is already defined in remote schema.

@Ackar
Copy link
Author

Ackar commented Jan 5, 2021

@AlexDerbenew It does work properly overriding remote types fields.

For example, running graphql-faker --extend http://swapi.apis.guru we can define the following extension schema:

extend type Film {
  title: String @override @fake(type: words)
}

@Ackar
Copy link
Author

Ackar commented Feb 2, 2021

@IvanGoncharov Any thoughts on this?

@NShahri
Copy link

NShahri commented May 4, 2021

@IvanGoncharov is there any plan to merge or support this feature?

@moimikey
Copy link

this is the only thing stopping me from continuing to use this lib. @override is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants