Fix matplotlib colormap deprecation warnings for 3.11 compatibility #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace matplotlib.cm.get_cmap() with matplotlib.colormaps.get_cmap() - Replace plt.get_cmap() with matplotlib.colormaps.get_cmap() - Update cebra/integrations/plotly.py, matplotlib.py, and tests/test_plotly.py - Remove matplotlib<3.11 version pin from setup.cfg - Ensures future compatibility with matplotlib 3.11+ releases Fixes AdaptiveMotorControlLab#240
|
Thank you for your contribution. We require contributors to sign our Contributor License Agreement (CLA). We do not have a signed CLA on file for you. In order for us to review and merge your code, please sign our CLA here. After you signed, you can comment on this PR with |
Contributor
Author
|
@cla-bot check |
|
Thanks for tagging me. I looked for a signed form under your signature again, and updated the status on this PR. If the check was successful, no further action is needed. If the check was unsuccessful, please see the instructions in my first comment. |
MMathisLab
approved these changes
Sep 14, 2025
Member
MMathisLab
left a comment
MMathisLab
left a comment
There was a problem hiding this comment.
Lgtm- thanks for contributing!
Member
|
Lgtm -- the failing windows test is unrelated (#270). Fine to merge from my end, @MMathisLab ? |
MMathisLab
merged commit a558ec6
into
AdaptiveMotorControlLab:main
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240