Skip to content

Conversation

@mfogel
Copy link
Contributor

@mfogel mfogel commented Feb 24, 2022

Hi, this commit to bump dependency minor versions seems to have caused two problems.

The first issue is simple: it caused package.json and package-lock.json to get out-of-sync.

The second issue is more complicated:

  • it bumped the minimum typescript version from 4.2.4 to 4.5.5
  • however, @typescript-eslint/eslint-plugin and @typescript-eslint/parser are still on the 4.x line, and don't support typescript 4.5.X.

The result is when sls package is run the following warning is printed to the console:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

To support typescript 4.5.X, @typescript-eslint/eslint-plugin and @typescript-eslint/parser would need to be upgraded to the next major version.

Until that's done, it might be a good idea to relax the version requirement on typescript to include the 4.4.X line. That's what this PR does.

This PR also updates package-lock.json so it's consistent with package.json.

Appears it was out of sync with package.json
For compatibility with other packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant