Update HomeController.cs #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On line 93 and line 94, based on the variables "cartTotal" and "arrayTotal", it seems to imply that author intends to show difference in getting total value from a ShoppingCart instance that also implements IEnumerable<Product> V.S. an array of Product objects In the original method, both "cartTotal" and "arrayTotal" are assigned with same set of products, from IEnumerable<Product> products This seems to contradict with the idea of comparison. Thanks for the source code though - it has been helpful.
|
This is accurate although there are several extra lines added in the commit that aren't required. The only change should be to the
|
Author
|
@ricktron3000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line 93 and line 94, based on the variables "cartTotal" and "arrayTotal",
it seems to imply that author intends to show difference in getting total value from
a ShoppingCart instance that also implements IEnumerable V.S.
an array of Product objects
In the original method, both "cartTotal" and "arrayTotal" are assigned with same set of products, from
IEnumerable products
This seems to contradict with the idea of comparison.
Thanks for the source code though - it has been helpful.