Upgrade base image to use PowerShell 7.4.11 #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolauli
requested changes
Sep 3, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM mcr.microsoft.com/powershell:lts-7.2-ubuntu-22.04 | |||
| FROM mcr.microsoft.com/dotnet/sdk:8.0.413-noble | |||
There was a problem hiding this comment.
Noble is Ubuntu 23, which is not a LTS version. Do we have image of Ubuntu 24.
tools/docker/Dockerfile
Outdated
| && apt-get -o Acquire::Check-Valid-Until=false install -y \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get update \ |
There was a problem hiding this comment.
This line is duplicated with line#4.
tools/docker/Dockerfile
Outdated
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get update \ | ||
| && apt-get install -y locales \ |
There was a problem hiding this comment.
Can we move this line up to be with the other install instructions so that apt-get clean could clean the package cache.
dolauli
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.