Sync eng/common directory with azure-sdk-tools for PR 12867 #6825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Copilot finished reviewing on behalf of
azure-sdk
November 12, 2025 19:23
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR #12867, updating the instructions for the Verify Setup tool to simplify the Python virtual environment handling workflow.
Key changes:
- Simplifies Python venv handling by removing the requirement to ask users for venvPath before running the tool
- Shifts to a post-execution approach where users are asked about the AZSDKTOOLS_PYTHON_VENV_PATH environment variable only when Python requirements fail
- Enhances documentation clarity around success conditions and resolution guidance
| Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed. | ||
| Display results in a user-friendly and concise format, highlighting any missing dependencies that need to be addressed and how to resolve them. | ||
|
|
||
| WHENEVER Python related requirements fail, ALWAYS ASK the user if they have set the `AZSDKTOOLS_PYTHON_VENV_PATH` system environment variable to their desired virtual environment. This tool can only check requirements in the venv path specified by that environment variable. |
There was a problem hiding this comment.
The instruction uses 'system environment variable' which may be ambiguous. Consider clarifying whether this should be an OS-level environment variable, a shell session variable, or both. For example: 'ALWAYS ASK the user if they have set the AZSDKTOOLS_PYTHON_VENV_PATH environment variable (system or shell-level) to their desired virtual environment path.'
Suggested change
| WHENEVER Python related requirements fail, ALWAYS ASK the user if they have set the `AZSDKTOOLS_PYTHON_VENV_PATH` system environment variable to their desired virtual environment. This tool can only check requirements in the venv path specified by that environment variable. | |
| WHENEVER Python related requirements fail, ALWAYS ASK the user if they have set the `AZSDKTOOLS_PYTHON_VENV_PATH` environment variable (either at the system/OS-level or in their current shell session) to their desired virtual environment path. This tool can only check requirements in the venv path specified by that environment variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12867 See eng/common workflow