[Storage] Decoupled Client Context Manager Methods from Base Client #41442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Placed context managers directly after constructors, removed those implementations from base client (sync / async) |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews azure-storage-blob |
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request decouples context manager methods from the base client into individual client implementations. The key changes include adding enter, exit, and close methods to various synchronous and asynchronous client classes, and removing these context manager methods from shared base classes.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_service_client.py | Added sync context manager methods (enter, exit, close) |
| sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py | Added sync context manager methods with pylint disable comment for too-many-public-methods |
| sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.py | Added sync context manager methods |
| sdk/storage/azure-storage-file-share/azure/storage/fileshare/_directory_client.py | Added sync context manager methods |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/aio/* | Added async context manager methods and adjusted generated client building |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/* | Removed context manager methods from shared base classes |
| sdk/storage/azure-storage-blob/azure/storage/blob/aio/* | Added async context manager methods |
| sdk/storage/azure-storage-blob/azure/storage/blob/* | Added sync context manager methods |
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_service_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_client_async.py
Show resolved
Hide resolved
...zure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_service_client_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.