Skip to content

Pylint 3.3.6 updates [azure-ai-ml] #41614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PratibhaShrivastav18
Copy link
Member

Description

Compatible with pylint 3.3.6
image

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 07:33
@PratibhaShrivastav18 PratibhaShrivastav18 enabled auto-merge (squash) June 17, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates logging in several modules to improve clarity and consistency when handling exceptions with pylint 3.3.6.

  • Standardizes exception logging by separating concise user‐facing messages and detailed debug logs.
  • Removes exception interpolation from warning/error logs in favor of dedicated debug logging.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_workspace_operations_base.py Updates logging for duration errors by splitting warning and debug logs.
sdk/ml/azure-ai-ml/azure/ai/ml/operations/_component_operations.py Splits exception log messages into info/error and debug logs for more consistent logging.
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/job.py Changes exception logging level from info to debug and adds an info log for failure.
sdk/ml/azure-ai-ml/azure/ai/ml/_utils/_artifact_utils.py Updates artifact tool path logging to separate warning and debug details.
sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py Refines logging messages by removing exception details from warnings and adding debug logs.
sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_deployment_executor.py Updates polling exception logging to display exception type only in the debug log.
Comments suppressed due to low confidence (2)

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/job.py:337

  • [nitpick] Check if lowering the logging level for exceptions might obscure error context during parsing issues; ensure that the operational logging configuration captures sufficient details.
module_logger.debug("Exception: %s.\n%s\nUnable to parse the job resource: %s.\n",

sdk/ml/azure-ai-ml/azure/ai/ml/_azure_environments.py:301

  • [nitpick] Verify that removing the exception details from the warning log does not hinder troubleshooting connectivity or configuration issues in certain environments.
module_logger.warning("Error: Azure ML was unable to load cloud metadata from the metadata url.")

@PratibhaShrivastav18 PratibhaShrivastav18 enabled auto-merge (squash) June 20, 2025 05:55
@PratibhaShrivastav18 PratibhaShrivastav18 merged commit 9a5ad7c into Azure:main Jun 20, 2025
24 checks passed
@PratibhaShrivastav18 PratibhaShrivastav18 deleted the shrivastavp/pylint_updates branch June 20, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants