Fix the issue with corehttp not being set to nightly alpha version
#41629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the nightly builds for corehttp were using an incorrect package version by adjusting the file search logic in the version parsing module.
- Updated recursive search to traverse the full package directory instead of a hardcoded "azure" subfolder.
- Simplified the comment to better reflect the new search scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title!
The failure is visible here.
This has been failing for a while now and I just never did the digging to understand why. If you check the
PackageInfofor the build I linked above, you will find all the packages have been dev versioned except forcorehttp. Due to the bug in set dev version, we are building/publishing the1.0.0b7version that's in the repo. Because we don't publish that version until after pypi release, the nightly doc publishing is failing to build docs forcorehttpbecause it's going after a package version that doesn't exist on the feed yet instead of thenightly alphaversion that the docs build is intended to work with.This PR fixes the set_dev_version and ensures everything is in alignment.