Skip to content

[AutoRelease] t2-storageactions-2025-06-19-93553(can only be merged by SDK owner) #41665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk
Copy link
Collaborator Author

@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 07:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the StorageActions Management package for production release by updating stability indicators, dependency versions, and supported Python versions while also aligning the asynchronous and synchronous operation interfaces with recent API changes. Key changes include:

  • Update of development status in setup.py (from Beta to Production/Stable) and python_requires from ">=3.8" to ">=3.9".
  • Marking the package as stable in sdk_packaging.toml.
  • Updates to polling options in operations and modifications in test files regarding the values for "onFailure" and "onSuccess".

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Updated development status, azure-mgmt-core version, and Python version requirements.
sdk_packaging.toml Updated stability flag from false to true.
test_storage_actions_mgmt_storage_tasks_operations_async.py Changed "onFailure" and "onSuccess" values from expected enum strings to "str".
test_storage_actions_mgmt_storage_tasks_operations.py Similar changes in "onFailure" and "onSuccess" values impacting test expectations.
Other files Various improvements in type annotations and polling option adjustments in operations and asynchronous clients.
Comments suppressed due to low confidence (2)

sdk/storageactions/azure-mgmt-storageactions/generated_tests/test_storage_actions_mgmt_storage_tasks_operations_async.py:44

  • The test modifications change the 'onFailure' and 'onSuccess' values from 'break' and 'continue' to 'str', which do not match the defined enum values in OnFailure and OnSuccess. Verify if these changes are intentional or if the tests should use the proper enum string values.
                                        "onFailure": "str",

sdk/storageactions/azure-mgmt-storageactions/generated_tests/test_storage_actions_mgmt_storage_tasks_operations.py:45

  • The synchronous test files now use 'str' for 'onFailure' and 'onSuccess' instead of the expected values ('break'/'continue') as defined by the new enums. Please review whether this change is correct or if the tests should be updated to reflect the correct enum values.
                                {"name": "str", "onFailure": "str", "onSuccess": "str", "parameters": {"str": "str"}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant