Sync eng/common directory with azure-sdk-tools for PR 10949 #41690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add basic tag support beta or latest - Add tag validation for ESRP - Support subpaths from the artifact to scope to just some packages -
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with the latest changes from azure-sdk-tools, updating script commands and pipeline templates to improve consistency and functionality. Key changes include:
- Updating the PowerShell script to use the explicit Sort-Object cmdlet.
- Adding a new parameter (CustomCondition) to the npm authentication step template.
- Enhancing the npm-publish job with new parameters, refined tag logic, and additional conditions for improved publishing control.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/copy-docs-to-blobstorage.ps1 | Updated version sorting to use Sort-Object for clearer, consistent PowerShell usage. |
| eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml | Introduced CustomCondition parameter with a default value to govern task execution. |
| eng/common/pipelines/templates/jobs/npm-publish.yml | Modified parameters (Tag, ArtifactSubPath, DeploymentName, Pool, and CustomCondition) and publishing logic, including tag determination and conditional steps for package publishing. |
Comments suppressed due to low confidence (2)
eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml:6
- [nitpick] Consider adding an inline comment that explains the purpose and expected behavior of the CustomCondition parameter to improve maintainability for future updates.
- name: CustomCondition
eng/common/pipelines/templates/jobs/npm-publish.yml:61
- [nitpick] Consider adding inline comments to clarify the logic for determining the publishing tag (resetting to 'latest' or 'beta' as appropriate) to aid future maintainers and reviewers.
$tag = '${{ parameters.Tag }}'
weshaggard
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10949 See eng/common workflow