must be python3.10 for uv-seed #41695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0lawrence
changed the title
scbedd
approved these changes
Jun 20, 2025
|
/azp run python - appconfiguration - ci |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures UV seed commands run with Python 3.10 and standardizes pip invocations in tox.
- Default
pip_implnow usespython -m pip. - Removed redundant
python -mwrappers in install commands. - Pinned the MCP server’s Python requirement to 3.10 and adjusted the
tox-uvversion constraint.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/tox/tox.ini | Switched default pip implementation to python -m pip and updated install verbs. |
| eng/tools/mcp/azure-sdk-python-mcp/pyproject.toml | Changed requires-python to ==3.10.* and lowered tox-uv minimum version. |
Comments suppressed due to low confidence (3)
eng/tox/tox.ini:28
- Update this comment to reflect that the default pip implementation is now
python -m pipinstead of plainpip.
# Set TOX_PIP_IMPL=uv pip to use uv pip, or TOX_PIP_IMPL=pip (default) to use standard pip
eng/tools/mcp/azure-sdk-python-mcp/pyproject.toml:6
- [nitpick] The
requires-pythonconstraint is pinned to==3.10.*, which prevents patch-level Python 3.10 updates and disallows Python 3.11+. Consider using a range like>=3.10,<4.0unless exact pinning is required.
requires-python = "==3.10.*"
eng/tools/mcp/azure-sdk-python-mcp/pyproject.toml:16
- [nitpick] The minimum version constraint for
tox-uvwas lowered from>=1.26.0to>=1.25.0. Please confirm that this change aligns with compatibility requirements and does not reintroduce fixes made in newer releases.
"tox-uv>=1.25.0",
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scbedd
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinning to 3.10 for now for setuptools, and making default python -m so uv can run properly