-
Notifications
You must be signed in to change notification settings - Fork 2
UI Improvements, Upload Constraints & Space Reorganization #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I can't merge this PR because of a conflict. Can you please check and resolve it? |
please @bruehle do not merge anything until we solve conversations and changes |
…helper into 9-add-personal-token-as-alternative-for-login
|
@JosePizarro3 I think everything is done for this PR. Could you review it? |
JosePizarro3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, some minor comments, especially about inspecting browsers to get to debug html and css files :)
| <p>Resets Card 2 and 3</p> | ||
| </div> | ||
| </div> | ||
| <div class="parser-tooltip-group card-corner" style="text-align: right;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this next to the buttons for Upload Files and the restart.
Would be nice to have it in the right corner.
The problem is that we have 3 elements (their class names are btn btn-primary , parser-tooltip-group and parser-tooltip-group card-corner) right now living in separate divs. I would suggest grouping them in one single div, and organizing them properly. I can help you if you want, but I want you to also get use to go to INSPECT in a browser and identify this problem first.
This pull request introduces a range of user-facing and backend improvements, including new authentication options, space list reorganization, UI dropdown enhancements, and uploads hardening through file size limits and timeouts.
Included Changes
#9 Add personal token as alternative for login
Introduces token-based authentication as an alternative to password login.
#10 Reorganize available spaces
Improved ordering logic so BAM_* and VP._ spaces appear in a predictable structure.
#11 Optional Collection
Updated the UI and backend logic to support optional collections.
#12 Bump bam-masterdata version
Updated dependency to the latest compatible release.
#13 Move list of available parsers to card 1
Reworked UI layout to make parser selection more intuitive.
#14 Dropdown menus for project and (optionally) collection
Added dynamic dropdowns for project and collection selection.
#16 Add max size of uploaded files and timeouts
Added input validation and safety limits to large uploads. (no processing timeout)