fixes a bug in instruction encoding propagation #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
approved these changes
Feb 7, 2023
ivg
changed the title
Member
|
I changed the title to reflect that it is not just a relaxation but actually a bug fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In binaries with interworking, it is expected that the destinations of some control flow instructions will have a different encoding than said instructions (e.g.
blxon ARM/Thumb). However, the rules in the disassembler were too restrictive, as they assumed that the destination encoding would have a join with the source encoding.This PR relaxes the restriction by assuming at first the
Theory.Language.unknownencoding. If no encoding can be found then we can then assume that the source encoding is to be used.