-
Notifications
You must be signed in to change notification settings - Fork 57
Fixes #159 Implemented Custom Logs for both environments - Development and Production. #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #159 Implemented Custom Logs for both environments - Development and Production. #160
Conversation
@SamakshAgarwal1112 I have fixed the issue #159 and opened a PR for the same #160 |
@ritankarsaha Good work. Although a few changes are required!!
|
@SamakshAgarwal1112 Made the necessary changes and pushed a new commit into the PR.
PROOF OF WORK Screen.Recording.2024-06-22.at.11.mp4 |
@ritankarsaha Good work. A last few changes are required.
|
@SamakshAgarwal1112 Added the filters, and made the changes as asked. PROOF OF WORKScreen.Recording.2024-06-22.at.7.mp4Thank You |
@ritankarsaha LGTM. Just change the way you are choosing handlers and their levels. Currently, You are checking if the environment is development, rather you should check if the environment is production, and choose according to that. |
@SamakshAgarwal1112 Made the necessary changes and pushed a new commit into the PR. Thank You. |
@SamakshAgarwal1112 used os.environ.get() instead of os.getenv() for checking variables while still in production. |
@ritankarsaha Good work. |
Fixes #159
Description:-
This PR does the following:-
PROOF OF WORK:-
Screen.Recording.2024-06-21.at.7.mp4
Thank You.