-
Notifications
You must be signed in to change notification settings - Fork 57
Fixes #168 Updated the entire Awards Section #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #168 Updated the entire Awards Section #169
Conversation
@SamakshAgarwal1112 I have made the changes, fixed issue #168 and opened a PR for the same. |
@ritankarsaha Good effort. Here are a few suggestions from my side :
|
@SamakshAgarwal1112 Updated the changes as deemed. |
@SamakshAgarwal1112 Made the changes in the models.py for trimming and added ProcessedImageField for image resizing |
@ritankarsaha Great work! Last few tweaks though! Resize the image to 300x300. And center align the image in both, index and specific awards page. |
@SamakshAgarwal1112 Made the changes and pushed new commits into the PR |
@ritankarsaha LGTM. Well done. |
FIXES
This PR fixes the issue #168 .
DESCRIPTION:-
This PR does the following making changes in a number of files:-
Updates the models.py of the awards app in the applications folder to incorporate the image field
image = models.ImageField(upload_to='awards/images/', null=True, blank=True)
and also incorporate the received_by fieldreceived_by = models.CharField(max_length=255, null=True, blank=True)
Updates the views.py file in the same location, to display a limited portion of each award in the All Awards page or the index.html page and other fixes.
Updates the urls.py file in the same location to incorporate double-digit ids as well instead o ids ranging from [0-9] only.
Updates the award.html file so that the image can be displayed, received_by attribute be displayed and the whole content too. Lastly UI fixes.
Updates the index.html file so that all the awards are displayed in an orderly fashion with images right aligned and the description if too long contains a gist of the original content. Lastly UI fixes.
PROOF OF WORK:-
PORTION 1
Screen.Recording.2024-07-07.at.4.mp4
This video shows two essential fixes:-
These two images show the image displayed both in the index.html page with all the awards, and in the award.html page where only the specified award is displayed.
PORTION 2
Screen.Recording.2024-07-07.at.4.1.mp4
This video shows the fix:-
Screen.Recording.2024-07-07.at.5.mp4
This video is in accordance with the previous video showing that while in the award-list page or the index.html page the long text gets trimmed to a smaller chunk and when the corresponding award page of that particular award(award.html) page is opened, the entire text is displayed properly.
The UI too has been fixed accordingly.
Thank You.