Run changed checkoutScript in build-only mode #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asDigestScript() method of import SCMs erroneously did not include the 'dir' attribute. This cannot easily be fixed because it will directly affect the variant-id and thus cause rebuilds and invalidate existing binary artifacts. Instead, the fixImportScmVariant policy is introduced to enable fixing the bug for new projects without breaking old ones.
The tracking of recipe changes was not sufficient for build-only updates of checkouts that involve the import-SCM or recipes that utilize checkoutUpdateIf. We were over-cautious and prevented running these updates if *anything* related to the checkout step changed. To make Bobs behaviour more predictable, track the related state more closely. Updates of checkouts in build-only mode are now only prevented if an import-SCM is changed. On the other side, changes to the checkoutScript will trigger the update in build-only mode even if the script is deterministic. Fixes BobBuildTool#506.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 88.18% 88.22% +0.04%
==========================================
Files 46 46
Lines 14433 14493 +60
==========================================
+ Hits 12728 12787 +59
- Misses 1705 1706 +1
☔ View full report in Codecov by Sentry. |
|
👍 Did some testing today -> works as expected now. |
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a recipe utilizes
checkoutUpdateIf, relax the checks so that also modifiedcheckoutScripts are run in build-only mode.@rhubert Could you please give it a try?