Fix garbling of shared packages #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages at shared locations are immutable. If the recipe was changed and the package is unshared, the workspace link in the project tree is removed. Problem is, the os.path.isdir() function returns True for symlinks that point to directories. This actually then clears the shared location instead of removing the link. Fix it by reversing the condition. Fixes BobBuildTool#522.
Make sure that unsharing a package does not garble the shared location.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 78.78% 88.18% +9.39%
==========================================
Files 46 46
Lines 14460 14460
==========================================
+ Hits 11393 12751 +1358
+ Misses 3067 1709 -1358
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.