msys: fixed version handling

[mahaase]

there is no CYGWIN_VERSION_DLL_EPOCH anymore. epoch and major has to be calculated. define CYGWIN_VERSION_DLL_MAJOR 3004 means version 3.4.x.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (fd2f913) 88.18% compared to head (9e6a031) 88.20%.
Report is 32 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   88.18%   88.20%   +0.02%     
==========================================
  Files          46       46              
  Lines       14430    14493      +63     
==========================================
+ Hits        12725    12784      +59     
- Misses       1705     1709       +4     

Files Changed	Coverage Δ
pym/bob/languages.py	89.83% <ø> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jkloetzke]

It looks like CYGWIN_VERSION_DLL_EPOCH was simply removed with no apparent reasoning given. 🤔 I would propose to use -1 in case it's undefined to keep compatibility with older installations:

#ifndef CYGWIN_VERSION_DLL_EPOCH
#define CYGWIN_VERSION_DLL_EPOCH -1
#endif

Otherwise the fingerprint would not be backwards compatible...

[mahaase]

maybe like this?

printf("%s/%d.%d.%d\n", CYGWIN_VERSION_DLL_IDENTIFIER,
#ifdef CYGWIN_VERSION_DLL_EPOCH
        CYGWIN_VERSION_DLL_EPOCH,
        CYGWIN_VERSION_DLL_MAJOR,
#else
        CYGWIN_VERSION_DLL_MAJOR / 1000,
        CYGWIN_VERSION_DLL_MAJOR % 1000,
#endif
        CYGWIN_VERSION_DLL_MINOR);

[jkloetzke]

Sure, that's also possible...

[mahaase]

updated. 👍

[jkloetzke]

Thanks!