cmds/archive: fix lost exception #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A return in the finally block silently swallows the exception instead of reraising it. This caused archive scanning to be silently stopped on a exception and results in many unhandled archives.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 48 48
Lines 15614 15614
=======================================
+ Hits 13889 13890 +1
+ Misses 1725 1724 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wow. Very subtle. Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A return in the finally block silently swallows the exception instead of reraising it. This caused archive scanning to be silently stopped on a exception and results in many unhandled archives.