Add regular expression substitution string function #643
+128
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch the re.error exception and convert it into a proper parsing error.
Unfortunately we missed the opportunity to reserve a namespace for Bob internal string functions. Adding new ones thus has the potential to break existing plugins. New functions are now added as a last step in the parsing process. If a plugin has already declared a function with the same name, issue a warning. The plugin function will be kept to not break existing projects.
Perform regular expression substitution.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 50 50
Lines 16023 16049 +26
=======================================
+ Hits 14253 14277 +24
- Misses 1770 1772 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Internal string functions (such as resubst) that are added after Bob 1.0 might collide with existing plugins. Verify that a warning is issued and that the plugin function is called instead of the internal implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.