Robust archive downloads #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When downloading from an archive, the build should not fail because of network errors. After all, the binary archive is just a cache that might not provide an archive. We now treat any errors up to and including the connection establishment as warnings. Previously, refused connections were already treated that way. For uploads the behaviour does not change. Any network errors are treated as errors for uploads. Fixes BobBuildTool#660.
The "nofail" option actually is only relevant for uploads. Name the internal variable accordingly.
The option only affects uploads.
By default, downloads from archives ignore most errors. Usually, this is desired because this is just a different reason why no artifact is found. But in CI environments, unreachable servers or similar problems should never happen. For that, the "strictdownload" flag indicates that the server must be reachable and respond properly. In any case, it is never an error if a download does not find the requested archive, even with the strictdownload flag. See BobBuildTool#660.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 88.97% 89.01% +0.03%
==========================================
Files 50 50
Lines 16124 16127 +3
==========================================
+ Hits 14347 14356 +9
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.