Skip to content

Automation store builder updates #16065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

deanhannigan
Copy link
Contributor

Description

Some overdue refactoring of the automation store and the introduction of store unit tests. There has also been a lot of change to the store recently, with more to come, so it made sense to get a good start of cleaning up the core store.

Addresses

  • Restructure of the entire store to bring it in line with other stores in the builder.
  • Initial unit test pass of the automation store.
  • Fix There was an issue with the BudiStore class that meant the initiating config structure would be mutated during the lifespan of an extending store. This wasn't an issue in production as the stores are all treated as singletons. In a test class with 1 or more instances of the same store in play, it became apparent that state mutations were persisting between tests.

Launchcontrol

Automation store refactoring, new tests and fixes

Copy link

qa-wolf bot commented May 2, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the stale label May 13, 2025
@github-actions github-actions bot closed this May 27, 2025
@deanhannigan deanhannigan reopened this May 27, 2025
@github-actions github-actions bot removed the stale label May 27, 2025
@github-actions github-actions bot added the stale label Jun 3, 2025
@github-actions github-actions bot closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant