Automation store builder updates #16065
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some overdue refactoring of the automation store and the introduction of store unit tests. There has also been a lot of change to the store recently, with more to come, so it made sense to get a good start of cleaning up the core store.
Addresses
BudiStore
class that meant the initiating config structure would be mutated during the lifespan of an extending store. This wasn't an issue in production as the stores are all treated as singletons. In a test class with 1 or more instances of the same store in play, it became apparent that state mutations were persisting between tests.Launchcontrol
Automation store refactoring, new tests and fixes