Fix unhandled promise rejection in utils.parallelForeach #16362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation had a critical bug where Promise.race() was called without proper error handling, causing unhandled promise rejections when parallel tasks failed. This was particularly problematic in GoogleSheets integration where getRows() failures would become unhandled rejections. Changes: - Completely rewrote parallelForeach with proper error handling - Added comprehensive tests to verify no unhandled promise rejections - Fixed concurrency control logic and promise cleanup - All existing functionality preserved while eliminating the race condition 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Rewrote parallelForeach with a simpler, more robust worker-based approach: - Eliminated complex Promise.race logic that was causing unhandled rejections - Uses worker functions that process items sequentially from shared index - Proper error propagation through Promise.all - All tests now pass with 0 unhandled promise rejections - Cleaned up test structure and removed old test file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…led-promise-rejection-parallel-foreach
mike12345567
approved these changes
Jun 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation had a critical bug where Promise.race() was called without proper error handling, causing unhandled promise rejections when parallel tasks failed. Unhandled promises cause container restarts in prod.