Multi-channel processing with mono IRs, and updated docs #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances multi-channel processing by adding support for using mono impulse responses (IRs) in convolution tests and updating the corresponding documentation. Key changes include:
- Adding a new boolean parameter (mono_ir) to control IR processing in test_convolution_multi_channel.
- Introducing and documenting create_multichannel_process_state in the public API.
- Updating README examples to illustrate both basic mono IR usage and multi‑channel processing.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/chowdsp_convolution_test.cpp | Expanded multi-channel test function to support mono IR processing. |
| chowdsp_convolution.h | Added documentation and function declaration for multichannel process state creation. |
| chowdsp_convolution.cpp | Implemented create_multichannel_process_state and updated multi-channel processing logic. |
| README.md | Updated examples to cover both mono and multi‑channel usage. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.