Skip to content

Small cleanup for the spec_helper file and jruby support #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 8, 2014

Conversation

seuros
Copy link
Member

@seuros seuros commented May 18, 2014

No description provided.

@seuros
Copy link
Member Author

seuros commented May 18, 2014

I added jruby to travis matrix.

Concurrency test are excluded since they are failing in jruby. I think we should use barrier .

PS: can we turn on the rbx tests again ?

@seuros seuros changed the title Small cleanup for the spec_helper file Small cleanup for the spec_helper file and jruby support May 18, 2014
@mceachen
Copy link
Collaborator

mceachen commented Jun 1, 2014

Wow, dude, this was a lot of work. Thanks!

@seuros
Copy link
Member Author

seuros commented Jun 1, 2014

I didn't finish. I want to rewrite the parallel tests but i still need to understand the current ones.

@mceachen mceachen merged commit 4b92116 into ClosureTree:master Jun 8, 2014
@mceachen
Copy link
Collaborator

mceachen commented Jun 8, 2014

I turned on the rbx tests, but disabled all the head versions, as the travis build was taking hours for each run. We can uncomment them occasionally just to check.

@mceachen
Copy link
Collaborator

mceachen commented Jun 8, 2014

I had to allow_failures for jruby and rbx. If you have time to look into why they're failing, that'd be great, but I want to fix the sort_order bugs first.

Thanks again for all your help, sir. Much appreciated!

@seuros seuros deleted the yaml branch June 13, 2014 18:34
@seuros
Copy link
Member Author

seuros commented Jun 13, 2014

@mceachen , the change log don't make reference to the feature and the rspec matcher i added.

@mceachen
Copy link
Collaborator

Darn. I'll restore it.

Matthew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants