Prevent name collision with other gems: allowing the use of has_closure_treemethod besides acts_as_tree

[eturino]

Scenario: one of your dependencies uses other gem like Ancestry, while you want to use this gem for its multiple benefits. Even if that dependency uses the has_ancestry method instead of the acts_as_tree method, it will overwrite ClosureTree's acts_as_tree, render it useless. If we can still use another method like has_closure_tree, we can still work with this.

This way, the user can choose between using has_closure_tree (more intention revealing name in terms of what tool we want to use, IMO) or the generic acts_as_tree as before.

I changed one of the models of the specs to use the has_closure_tree method while leaving the rest using the acts_as_tree method to ensure that everything keeps working as expected.

[mceachen]

LGTM. We may want to add a caveat that other hierarchical gems won't place
nice against the same model. That might not be obvious to all casual
observers.

BTW, what are you missing from ancestry?
On Oct 14, 2014 6:53 AM, "Eduardo Turiño" [email protected] wrote:

Scenario: one of your dependencies uses other gem like Ancestry, while you
want to use this gem for its multiple benefits. Even if that dependency
uses the has_ancestry method instead of the acts_as_tree method, it will
overwrite ClosureTree's acts_as_tree, render it useless. If we can still
use another method like has_closure_tree, we can still work with this.

This way, the user can choose between using has_closure_tree (more
intention revealing name in terms of what tool we want to use, IMO) or the
generic acts_as_tree as before.

I changed one of the models of the specs to use the has_closure_tree
method while leaving the rest using the acts_as_tree method to ensure

that everything keeps working as expected.

You can merge this Pull Request by running

git pull https://github.com/eturino/closure_tree has_closure_tree

Or view, comment on, or merge it at:

#130
Commit Summary

• Prevent name collision with other gems: allowing the use of
  has_closure_tree beside method besides acts_as_tree

File Changes

• M README.md
  https://github.com/mceachen/closure_tree/pull/130/files#diff-0 (6)
• M lib/closure_tree/acts_as_tree.rb
  https://github.com/mceachen/closure_tree/pull/130/files#diff-1 (4)
• M spec/db/models.rb
  https://github.com/mceachen/closure_tree/pull/130/files#diff-2 (2)

Patch Links:

• https://github.com/mceachen/closure_tree/pull/130.patch
• https://github.com/mceachen/closure_tree/pull/130.diff

—
Reply to this email directly or view it on GitHub
#130.

[seuros]

BTW, what are you missing from ancestry?

I think the gem he is using depend on ancestry.

[kubum]

looks good 👍

[eturino]

Indeed that is the case: a dependency of my app uses ancestry.

[eturino]

@mceachen I updated the README doc.

[eturino]

@mceachen increased language strength in the warning section of the README as requested :)

[eturino]

@mceachen anything else I can do, or is it ready to be merged? :)

[seuros]

Please squash your commits.

[eturino]

@seuros squashed

[seuros]

@eturino Thank you 💚