Check db connection #215
Check db connection #215
Conversation
|
This was causing me problems as well. Because closure_tree is not correctly determining that we are in the deployment phase, it tries to connect to the database but fails since the containers haven't been hooked up yet. Could this be merged in so that we can use closure tree in these environments? |
|
Thanks for the PR! I'll try to review it tonight.
|
| attr_accessor :app_name, :database_less | ||
|
|
||
| def initialize | ||
| @app_name = 'Amazing app' |
There was a problem hiding this comment.
could you explain why we have an app name here ?
There was a problem hiding this comment.
In this momment that configuration is not used, first commit add the configuration file I thought would be weird a configuration file with no configurations that's why I added that also it can be deleted
|
Thanks @mceachen! Let me know if there is something I can do to help this get merged in faster |
|
Hi @mceachen it's something that I can do to help with this? |
|
I'll be able to cut a new release when I get access to a computer at the
end of July. Thanks for your patience.
|
|
@aaroalan remove the unused config and update the changelog. |
This configuration avoid error if db is unavailable.
aaroalan
force-pushed
the
check_db_connection
branch
from
221e9bd to
374ad90
Compare
|
@seuros, I updated PR with your comments. Thanks |
|
thank you @aaroalan |
Class
has_closure_tree.rbwas validating only the Heroku config unfortunately other PaaS like Catalyze does not have the same configuration, after this PR will be posible create a config file and skip the error when app is deployed for one of those platforms.