Fix _ct.scope_with_order when no order_column is specified #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accept `additional_order_by` attribute
|
LGTM. Thanks! |
mceachen
added a commit
that referenced
this pull request
Aug 3, 2013
Fix _ct.scope_with_order when no order_column is specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ct.scope_with_order should accept
additional_order_byattribute even when no order_column is specified. It avoids failing Model.hash_tree when the tree_scope isn't ordered by generations and building the tree will fail athash_tree.rb:52because the parent_id isn't yet key in the hash.