Skip to content

Conversation

@not-matthias
Copy link
Member

Fixes #24

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #25 will not alter performance

Comparing cod-1504-fix-go-runner-with-vendor-folder (90629b1) with main (e272453)

Summary

✅ 24 untouched

@not-matthias not-matthias requested a review from Copilot October 15, 2025 12:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Go projects that use vendor directories by modifying the build command to use -mod=mod flag. This ensures that Go uses module mode instead of vendor mode, allowing the runner to work correctly with vendored dependencies.

  • Added -mod=mod flag to the Go build command to force module mode
  • Created a test case with a vendored project to verify the fix
  • Added integration test coverage for the vendor folder scenario

Reviewed Changes

Copilot reviewed 6 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go-runner/src/builder/mod.rs Added -mod=mod flag to force module mode during build
go-runner/src/integration_tests.rs Added test case for example-with-vendor project
go-runner/testdata/projects/example-with-vendor/main.go Created test project with basic functions for vendor testing
go-runner/testdata/projects/example-with-vendor/main_test.go Created test and benchmark functions using vendored testify dependency
go-runner/testdata/projects/example-with-vendor/go.mod Created module definition with testify dependency
go-runner/src/snapshots/codspeed_go_runner__integration_tests__assert_results_snapshots@example-with-vendor.snap Added expected test results snapshot for vendor test case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias requested a review from art049 October 15, 2025 12:17
@not-matthias not-matthias merged commit 90629b1 into main Oct 17, 2025
13 checks passed
@not-matthias not-matthias deleted the cod-1504-fix-go-runner-with-vendor-folder branch October 17, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Probably wrong vendoring

3 participants