[Manager] Implement search filters #4193
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify filter UI by using SearchFilterDropdown for all filters - Remove complex template logic with Dropdown and MultiSelect components - Use SearchFilterDropdown component for all filters (consistent with sort/mode dropdowns) - Remove multi-select support to simplify implementation - Add placeholder and clear functionality to SearchFilterDropdown
|
Can rebase on #4196 after it is merged, most likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getFilterableFields(): SearchFilter[]to node pack search provider interface, which all search providers must implement.Implements search filtering for Comfy Registry search provider, adjusting logic based on whether targeting
/nodesor/nodes/search(openapi spec) endpoints. Current filters are:OS and GPU filters should be auto-populated based on user's system.
Algolia filter implementation will be done in followup PR. When provider gives empty list of filters, the component is simply not rendered.
┆Issue is synchronized with this Notion page by Unito