[Manager] Fix "total nodes" count when selecting multiple packs #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the displayed "total nodes" count in the info panel when selecting multiple nodes at once.
api.comfy.org/nodes/{node_id}/comfy_nodeshas paginated responses. When not settinglimitin request, it defaults to 10. The component therefore always displayed packs with more than 10 individual nodes as having only 10. Fix by setting limit to high value for now.In followup, we will display concatenated preview of all nodes with lazy loading and infinite scroll. For determining length we will use the
totalNumberOfPagesfield in the response. Task┆Issue is synchronized with this Notion page by Unito