-
Notifications
You must be signed in to change notification settings - Fork 4
Various clean-up and fixes of markdown linting issues #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dd documentation for MarkdownNote node.
@benceruleanlu Can this PR be merged? Saw you self-requested to be a reviewer. Currently I'm fine with it. But it does update tons of files, and I can't review all of them. |
Maybe I can elaborate a little bit on the changes I have done: Inputs and Outputs TitlesI noticed the titles of inputs and outputs were inconsistent across nodes. They contained variety of values such as:
So the main changes here consist in standardizing these titles into two simple titles LintingThe markdown wasn't properly formatted. Easy stuff to fix was adding blank lines before / after titles, bullet points, at the end of the files, etc. This was done using the Others
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay 💤
quick question, is the ImageToMask copy folder supposed to exist?
also, feel free to open a feature request to make a bash equivalent of the .ps1 script, or just add that in this pr
overall great stuff--really appreciate the help 🌜
having a gh workflow to run markdownlint on PRs would be awesome as well, but that can be in a separate PR/issue looks good to go as is |
Oops, good catch! It's not supposed to be there. I'll clean it up.
I'll add it to that PR |
@benceruleanlu tested the bash script and it works. This is ready to be merged. |
Note
node.MarkdownNote
.en.md
es.md
fr.md
ja.md
ko.md
zh.md