Skip to content

Conversation

@DavePearce
Copy link
Collaborator

@DavePearce DavePearce commented Nov 19, 2025

This updates the build.gradle to ensure that the
downloadExecutionSpecFixtures task is triggered when running the tests, when previously it was not. There is still an oddity though, whereby the first time you do it, it will download the fixtures but then not run any actual tests. However, if you rerun then it does indeed run the tests.


Note

Introduce a Copy task and rewire task dependencies so execution-spec fixtures are downloaded and unpacked before generating blockchain tests.

  • Build/Gradle (reference-tests/build.gradle):
    • Add copyExecutionSpecFixtures (Copy) task to extract fixtures_develop.tar.gz into ./build/execution-spec-tests, depending on downloadExecutionSpecFixtures.
    • Update generateExecutionSpecBlockchainTests to depend on copyExecutionSpecFixtures (instead of directly on download), ensuring fixtures are unpacked before test generation.
    • Minor cleanup of task registration blocks.

Written by Cursor Bugbot for commit 649ae9e. This will update automatically on new commits. Configure here.

This updates the build.gradle to ensure that the
downloadExecutionSpecFixtures task is triggered when running the tests,
when previously it was not.  There is still an oddity though, whereby
the first time you do it, it will download the fixtures but then not run
any actual tests.  However, if you rerun then it does indeed run the
tests.
@DavePearce DavePearce linked an issue Nov 19, 2025 that may be closed by this pull request
@DavePearce DavePearce requested a review from amkCha November 19, 2025 04:58
}


tasks.register("generateExecutionSpecBlockchainTests", RefTestGenerationTask) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only working when done in 2 steps ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'm not really sure why though. Would be nice if we could fix that, but for another day.

@DavePearce DavePearce merged commit f4bf0af into arith-dev Nov 19, 2025
13 of 16 checks passed
@DavePearce DavePearce deleted the 2494-fix-reference-tests-task-generateexecutionspecblockchaintests branch November 19, 2025 06:49
amkCha pushed a commit that referenced this pull request Nov 20, 2025
This updates the build.gradle to ensure that the
downloadExecutionSpecFixtures task is triggered when running the tests,
when previously it was not.  There is still an oddity though, whereby
the first time you do it, it will download the fixtures but then not run
any actual tests.  However, if you rerun then it does indeed run the
tests.
jonesho pushed a commit that referenced this pull request Nov 24, 2025
This updates the build.gradle to ensure that the
downloadExecutionSpecFixtures task is triggered when running the tests,
when previously it was not.  There is still an oddity though, whereby
the first time you do it, it will download the fixtures but then not run
any actual tests.  However, if you rerun then it does indeed run the
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: reference tests task generateExecutionSpecBlockchainTests

3 participants