-
Notifications
You must be signed in to change notification settings - Fork 2
feat - version 2 of SDK #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup.py
Outdated
'setuptools', | ||
] | ||
VERSION='0.3.0' | ||
VERSION = '0.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will be 0.5.0
, we already have a 0.4.0
. The setup.py
wasn't updated last release.
if not 1024 <= args.port < 65536: | ||
raise AssertionError('port must be in range [1024, 65536)') | ||
def run(module: str): | ||
global _is_running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm curious why we need a global running flag?
@@ -0,0 +1,21 @@ | |||
config = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ther any way we can remove the need for globals and make these fields on an object? Trying to get away from globals, as they're typically a bad practice.
import os.path | ||
|
||
|
||
def load_config(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps make this name a bit more obvious, something like fs_load_config
Any, | ||
) | ||
|
||
LOG_LEVELS = {'DEBUG', 'INFO', 'WARN', 'WARNING', 'ERROR', 'CRITICAL'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for the internal impl details only? or is this something users will be tieing into?
Callable, | ||
) | ||
|
||
allowed_methods = {'DELETE', 'GET', 'HEAD', 'OPTIONS', 'PATCH', 'POST', 'PUT', } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we supporting HEAD
and OPTIONS
now?
dbc7584
to
3f6b564
Compare
3f6b564
to
f655f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets give it a whirl
Rewrite of the SDK to focus on usability.