Skip to content

Conversation

johns31459
Copy link
Collaborator

@johns31459 johns31459 commented Oct 2, 2023

Rewrite of the SDK to focus on usability.

  • Function decoration as opposed to base class extension.
  • Automatic routing.
  • Automatic registration of handlers.

setup.py Outdated
'setuptools',
]
VERSION='0.3.0'
VERSION = '0.4.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will be 0.5.0, we already have a 0.4.0. The setup.py wasn't updated last release.

if not 1024 <= args.port < 65536:
raise AssertionError('port must be in range [1024, 65536)')
def run(module: str):
global _is_running
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm curious why we need a global running flag?

@@ -0,0 +1,21 @@
config = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ther any way we can remove the need for globals and make these fields on an object? Trying to get away from globals, as they're typically a bad practice.

import os.path


def load_config():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps make this name a bit more obvious, something like fs_load_config

Any,
)

LOG_LEVELS = {'DEBUG', 'INFO', 'WARN', 'WARNING', 'ERROR', 'CRITICAL'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for the internal impl details only? or is this something users will be tieing into?

Callable,
)

allowed_methods = {'DELETE', 'GET', 'HEAD', 'OPTIONS', 'PATCH', 'POST', 'PUT', }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we supporting HEAD and OPTIONS now?

Copy link
Collaborator

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets give it a whirl

@johns31459 johns31459 merged commit b7f3b61 into main Oct 17, 2023
@johns31459 johns31459 deleted the feat/redesign branch October 24, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants