-
Notifications
You must be signed in to change notification settings - Fork 467
feat(ffe): integrate datadog-ffe #15098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
cef19ac to
b4dfcf7
Compare
b4dfcf7 to
762fd7f
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 3 ms. The average import time from base is: 237 ± 2 ms. The import time difference between this PR and base is: 0.4 ± 0.1 ms. The difference is not statistically significant (z = 2.82). Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate datadog-ffe (439a02b) with baseline main (635be97) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 3.122µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +6.8% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 205.141µs (SLO: <220.000µs -6.8%) vs baseline: +3.9% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.362µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +3.9% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.962µs (SLO: <220.000µs 🟡 -0.5%) vs baseline: +3.2% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.255µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +3.9% Memory: ✅ 31.988MB (SLO: <34.000MB -5.9%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 138.087µs (SLO: <150.000µs -7.9%) vs baseline: +1.5% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.196µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +4.7% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 219.361µs (SLO: <250.000µs 📉 -12.3%) vs baseline: +4.0% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.917ms (SLO: <22.000ms -4.9%) vs baseline: +5.9% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.2% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.308ms (SLO: <2.300ms +0.3%) vs baseline: +4.3% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.2% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.432ms (SLO: <1.550ms -7.6%) vs baseline: +2.6% Memory: ✅ 31.968MB (SLO: <34.000MB -6.0%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.272ms (SLO: <2.550ms 📉 -10.9%) vs baseline: +5.7% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.448µs (SLO: <20.000µs 📉 -77.8%) vs baseline: -3.9% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.148µs (SLO: <250.000µs 📉 -30.3%) vs baseline: -0.2% Memory: ✅ 31.988MB (SLO: <34.000MB -5.9%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.106ms (SLO: <2.500ms 📉 -15.7%) vs baseline: +0.4% Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.405ms (SLO: <22.300ms -8.5%) vs baseline: -0.6% Memory: ✅ 66.286MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ exception-replay-enabledTime: ✅ 1.339ms (SLO: <1.450ms -7.7%) vs baseline: -0.7% Memory: ✅ 64.382MB (SLO: <67.000MB -3.9%) vs baseline: +5.3% ✅ iastTime: ✅ 20.449ms (SLO: <22.250ms -8.1%) vs baseline: -0.5% Memory: ✅ 66.257MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ profilerTime: ✅ 15.492ms (SLO: <16.550ms -6.4%) vs baseline: -0.4% Memory: ✅ 53.955MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.636ms (SLO: <21.750ms -5.1%) vs baseline: +0.5% Memory: ✅ 66.172MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 25.321ms (SLO: <28.200ms 📉 -10.2%) vs baseline: +1.2% Memory: ✅ 67.309MB (SLO: <69.500MB -3.2%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.439ms (SLO: <21.750ms -6.0%) vs baseline: -0.2% Memory: ✅ 66.237MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ tracer-and-profilerTime: ✅ 22.603ms (SLO: <23.500ms -3.8%) vs baseline: -0.7% Memory: ✅ 67.476MB (SLO: <68.000MB 🟡 -0.8%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.262ms (SLO: <21.500ms 📉 -10.4%) vs baseline: -0.5% Memory: ✅ 66.237MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.3% ✅ tracer-minimalTime: ✅ 16.599ms (SLO: <17.500ms -5.1%) vs baseline: -0.4% Memory: ✅ 66.134MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 20.459ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 67.869MB (SLO: <72.500MB -6.4%) vs baseline: +5.3% ✅ tracer-no-cachesTime: ✅ 18.402ms (SLO: <19.650ms -6.4%) vs baseline: -0.1% Memory: ✅ 66.222MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-no-databasesTime: ✅ 18.731ms (SLO: <20.100ms -6.8%) vs baseline: -0.3% Memory: ✅ 65.844MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.110ms (SLO: <21.500ms -6.5%) vs baseline: -0.5% Memory: ✅ 66.237MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% ✅ tracer-no-templatesTime: ✅ 20.209ms (SLO: <22.000ms -8.1%) vs baseline: -0.1% Memory: ✅ 66.257MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.2% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.223ms (SLO: <19.850ms -8.2%) vs baseline: +1.2% Memory: ✅ 66.198MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +5.1% ✅ errortracking-enabled-userTime: ✅ 18.047ms (SLO: <19.400ms -7.0%) vs baseline: +0.3% Memory: ✅ 66.296MB (SLO: <66.500MB 🟡 -0.3%) vs baseline: +5.4% ✅ tracer-enabledTime: ✅ 18.195ms (SLO: <19.450ms -6.5%) vs baseline: +0.8% Memory: ✅ 66.001MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +5.4% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.070ms (SLO: <2.300ms 📉 -10.0%) vs baseline: -0.2% Memory: ✅ 52.632MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.7% ✅ errortracking-enabled-userTime: ✅ 2.066ms (SLO: <2.250ms -8.2%) vs baseline: -0.7% Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.6% ✅ tracer-enabledTime: ✅ 2.095ms (SLO: <2.300ms -8.9%) vs baseline: +1.2% Memory: ✅ 52.553MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.3% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: -0.1% Memory: ✅ 62.397MB (SLO: <65.000MB -4.0%) vs baseline: +5.1% ✅ appsec-postTime: ✅ 6.632ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: +0.2% Memory: ✅ 62.459MB (SLO: <65.000MB -3.9%) vs baseline: +5.2% ✅ appsec-telemetryTime: ✅ 4.588ms (SLO: <4.750ms -3.4%) vs baseline: ~same Memory: ✅ 62.376MB (SLO: <65.000MB -4.0%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 45.509MB (SLO: <47.000MB -3.2%) vs baseline: +5.8% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.160MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.547MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 52.774MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.4% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 52.772MB (SLO: <53.500MB 🟡 -1.4%) vs baseline: +5.5% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: +0.3% Memory: ✅ 54.261MB (SLO: <60.000MB -9.6%) vs baseline: +5.3% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.967ms (SLO: <4.200ms -5.5%) vs baseline: ~same Memory: ✅ 62.482MB (SLO: <66.000MB -5.3%) vs baseline: +5.1% ✅ iast-enabledTime: ✅ 2.447ms (SLO: <2.800ms 📉 -12.6%) vs baseline: -0.1% Memory: ✅ 59.277MB (SLO: <60.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.065ms (SLO: <2.250ms -8.2%) vs baseline: ~same Memory: ✅ 52.711MB (SLO: <54.500MB -3.3%) vs baseline: +5.4%
|
|
Tests fixed, libdatadog commit be5b5b22039141078d5e125824e338751f2d54a3 (branch avara1986/ffe-pyo3-methods) |
src/native/Cargo.toml
Outdated
| datadog-ddsketch = { git = "https://github.com/DataDog/libdatadog", rev = "v22.1.0" } | ||
| datadog-library-config = { git = "https://github.com/DataDog/libdatadog", rev = "v22.1.0" } | ||
| datadog-log = { git = "https://github.com/DataDog/libdatadog", rev = "v22.1.0" } | ||
| datadog-ffe = { git = "https://github.com/DataDog/libdatadog", rev = "36fe6be7f9a10f6cb44fc4f72ee33185c2a0cad1", features = ["pyo3"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the datadog-ffe module with the next libdatadog version
Description
Integrate WIP datadog-ffe from libdatadog: DataDog/libdatadog#1289
Testing
Tested manually that native bindings work:
More testing will be done as part of FFE feature.
Risks
Additional Notes
Ready for review but will need to wait for DataDog/libdatadog#1289 before merging.