-
Notifications
You must be signed in to change notification settings - Fork 467
feat(aiokafka): add DSM support for aiokafka #15112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dubloom/aiokafka-apm
Are you sure you want to change the base?
Conversation
Co-authored-by: Pieter Van Isacker <[email protected]>
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 2 ms. The average import time from base is: 239 ± 2 ms. The import time difference between this PR and base is: -1.32 ± 0.08 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate dubloom/aiokafka-dsm (84df845) with baseline dubloom/aiokafka-apm (3afdc42) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.348µs (SLO: <10.000µs 📉 -46.5%) vs baseline: 📈 +26.4% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 1.102µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +1.2% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.291µs (SLO: <10.000µs 📉 -37.1%) vs baseline: +3.0% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.297µs (SLO: <10.000µs 📉 -77.0%) vs baseline: ~same Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.552µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +0.6% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.582µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +2.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.853µs (SLO: <10.000µs 📉 -51.5%) vs baseline: +0.6% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.614µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.5% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.785µs (SLO: <10.000µs 📉 -62.1%) vs baseline: +2.9% Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +1.1% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.683µs (SLO: <10.000µs 📉 -53.2%) vs baseline: +3.0% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.2% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.8% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.403ms (SLO: <22.300ms -8.5%) vs baseline: -0.3% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.342ms (SLO: <1.450ms -7.5%) vs baseline: -0.1% Memory: ✅ 64.123MB (SLO: <67.000MB -4.3%) vs baseline: +4.7% ✅ iastTime: ✅ 20.480ms (SLO: <22.250ms -8.0%) vs baseline: +0.4% Memory: ✅ 66.001MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.623ms (SLO: <16.550ms -5.6%) vs baseline: +0.5% Memory: ✅ 53.859MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.532ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.513ms (SLO: <28.200ms -9.5%) vs baseline: +0.5% Memory: ✅ 67.099MB (SLO: <69.500MB -3.5%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.480ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.647ms (SLO: <23.500ms -3.6%) vs baseline: -0.3% Memory: ✅ 67.535MB (SLO: <68.000MB 🟡 -0.7%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.309ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 65.981MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.604ms (SLO: <17.500ms -5.1%) vs baseline: -0.8% Memory: ✅ 65.982MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 20.494ms (SLO: <21.750ms -5.8%) vs baseline: +0.4% Memory: ✅ 71.470MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.461ms (SLO: <19.650ms -6.1%) vs baseline: ~same Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-no-databasesTime: ✅ 18.748ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.667MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.086ms (SLO: <21.500ms -6.6%) vs baseline: -0.2% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.232ms (SLO: <22.000ms -8.0%) vs baseline: -0.3% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.112ms (SLO: <19.850ms -8.8%) vs baseline: +0.4% Memory: ✅ 66.041MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.376ms (SLO: <19.400ms -5.3%) vs baseline: +2.0% Memory: ✅ 66.060MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.229ms (SLO: <19.450ms -6.3%) vs baseline: +0.7% Memory: ✅ 65.686MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: ~same Memory: ✅ 62.276MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.625ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: +0.1% Memory: ✅ 62.308MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: -0.6% Memory: ✅ 62.299MB (SLO: <65.000MB -4.2%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 45.150MB (SLO: <47.000MB -3.9%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.2% Memory: ✅ 42.172MB (SLO: <49.000MB 📉 -13.9%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: ~same Memory: ✅ 46.206MB (SLO: <47.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: -0.3% Memory: ✅ 52.555MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.346ms (SLO: <3.650ms -8.3%) vs baseline: -0.4% Memory: ✅ 52.523MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.345ms (SLO: <3.650ms -8.4%) vs baseline: -0.1% Memory: ✅ 58.098MB (SLO: <60.000MB -3.2%) vs baseline: +4.9% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.972ms (SLO: <4.200ms -5.4%) vs baseline: -0.3% Memory: ✅ 62.266MB (SLO: <66.000MB -5.7%) vs baseline: +5.0% ✅ iast-enabledTime: ✅ 2.428ms (SLO: <2.800ms 📉 -13.3%) vs baseline: -0.5% Memory: ✅ 59.081MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.059ms (SLO: <2.250ms -8.5%) vs baseline: -0.5% Memory: ✅ 52.534MB (SLO: <54.500MB -3.6%) vs baseline: +4.9%
|
Description
Add DSM support for the aiokafka integration
Testing
Added DSM tests in
test_aiokafka_dsm.pyThis is a follow up of #10068
Thanks for your initial initial contribution @ls-pieter-vanisacker
This PR does not include a changelog because we are the using the same one as the APM PR one.
This PR requires #14961 to be merged before as well.