-
Notifications
You must be signed in to change notification settings - Fork 467
fix(ray): error when ray.init() was not called [backport 3.16] #15115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.16
Are you sure you want to change the base?
Conversation
Without an explicit `ray.init()` call at the beginning of the file, the ray job would fail because the `ray_trace_ctx` was not injected at the right moment. This PR fixes that Co-authored-by: Brett Langdon <[email protected]> (cherry picked from commit 0b92c07) Signed-off-by: Louis Tricot <[email protected]>
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 6 ms. The average import time from base is: 248 ± 6 ms. The import time difference between this PR and base is: -4.3 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-15087-to-3.16 (207e227) with baseline 3.16 (ab69c27) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.3% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.4% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -1.7% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.4% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.315µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -0.7% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 1.518µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.5% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.3% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.0% Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.1% ✅ bytes_aspectTime: ✅ 1.286µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -0.5% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.7% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.355µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -1.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.741µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.441µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.5% ✅ casefold_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ decode_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.8% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 0.423µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.7% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.0% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6% ✅ format_aspectTime: ✅ 3.464µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +3.2% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.513µs (SLO: <10.000µs 📉 -64.9%) vs baseline: -1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 0.779µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.2% Memory: ✅ 37.808MB (SLO: <39.000MB -3.1%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.6% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.281µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.7% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.316µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -1.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 2.608µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +1.2% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.366µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +6.7% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.558µs (SLO: <20.000µs 📉 -87.2%) vs baseline: 📈 +15.2% Memory: ✅ 37.827MB (SLO: <39.000MB -3.0%) vs baseline: +5.2% ✅ lstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 1.005µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +1.5% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.545µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 1.027µs (SLO: <10.000µs 📉 -89.7%) vs baseline: -0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.264µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +1.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.630µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.811µs (SLO: <10.000µs 📉 -51.9%) vs baseline: +0.1% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.2% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.9% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 0.909µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 1.892µs (SLO: <20.000µs 📉 -90.5%) vs baseline: -0.9% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.1% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.3% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.6% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.556µs (SLO: <10.000µs 📉 -84.4%) vs baseline: -0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ stringio_noaspectTime: ✅ 0.718µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.6% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 2.300µs (SLO: <20.000µs 📉 -88.5%) vs baseline: +4.6% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.391µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.9% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.429µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 2.340µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -1.0% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 0.503µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 37.768MB (SLO: <39.000MB -3.2%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.513µs (SLO: <10.000µs 📉 -64.9%) vs baseline: +8.1% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.261µs (SLO: <10.000µs 📉 -77.4%) vs baseline: +2.1% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 0.375µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 37.788MB (SLO: <39.000MB -3.1%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.533ms (SLO: <22.300ms -7.9%) vs baseline: +0.2% Memory: ✅ 65.156MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.2%) vs baseline: -0.5% Memory: ✅ 64.306MB (SLO: <67.000MB -4.0%) vs baseline: +4.8% ✅ iastTime: ✅ 20.487ms (SLO: <22.250ms -7.9%) vs baseline: ~same Memory: ✅ 65.136MB (SLO: <67.000MB -2.8%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.293ms (SLO: <16.550ms -7.6%) vs baseline: ~same Memory: ✅ 53.749MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.585ms (SLO: <21.750ms -5.4%) vs baseline: +0.2% Memory: ✅ 65.313MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.216ms (SLO: <28.200ms -7.0%) vs baseline: ~same Memory: ✅ 67.503MB (SLO: <69.500MB -2.9%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.503ms (SLO: <21.750ms -5.7%) vs baseline: +0.1% Memory: ✅ 65.146MB (SLO: <67.000MB -2.8%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.079ms (SLO: <23.500ms -6.0%) vs baseline: -0.3% Memory: ✅ 66.504MB (SLO: <67.500MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.357ms (SLO: <21.500ms -10.0%) vs baseline: ~same Memory: ✅ 65.107MB (SLO: <66.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.645ms (SLO: <17.500ms -4.9%) vs baseline: +0.2% Memory: ✅ 65.156MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.461ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 71.505MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.442ms (SLO: <19.650ms -6.1%) vs baseline: -0.3% Memory: ✅ 65.058MB (SLO: <67.000MB -2.9%) vs baseline: +4.6% ✅ tracer-no-databasesTime: ✅ 18.792ms (SLO: <20.100ms -6.5%) vs baseline: -0.1% Memory: ✅ 65.234MB (SLO: <67.000MB -2.6%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.161ms (SLO: <21.500ms -6.2%) vs baseline: -0.3% Memory: ✅ 65.185MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.359ms (SLO: <22.000ms -7.5%) vs baseline: +0.2% Memory: ✅ 65.195MB (SLO: <67.000MB -2.7%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.078ms (SLO: <19.850ms -8.9%) vs baseline: ~same Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.065ms (SLO: <19.400ms -6.9%) vs baseline: -0.3% Memory: ✅ 65.156MB (SLO: <66.500MB -2.0%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.035ms (SLO: <19.450ms -7.3%) vs baseline: -0.6% Memory: ✅ 65.077MB (SLO: <66.500MB -2.1%) vs baseline: +4.6% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.570ms (SLO: <4.750ms -3.8%) vs baseline: ~same Memory: ✅ 61.755MB (SLO: <65.000MB -5.0%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.546ms (SLO: <6.750ms -3.0%) vs baseline: -0.2% Memory: ✅ 61.833MB (SLO: <65.000MB -4.9%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.566ms (SLO: <4.750ms -3.9%) vs baseline: ~same Memory: ✅ 61.774MB (SLO: <65.000MB -5.0%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: -0.5% Memory: ✅ 45.475MB (SLO: <47.000MB -3.2%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: +0.2% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: +0.1% Memory: ✅ 46.576MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: ~same Memory: ✅ 52.081MB (SLO: <53.500MB -2.7%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.360ms (SLO: <3.650ms -7.9%) vs baseline: -0.6% Memory: ✅ 52.042MB (SLO: <53.500MB -2.7%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 58.324MB (SLO: <60.000MB -2.8%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.519ms (SLO: <47.150ms -9.8%) vs baseline: -0.1% Memory: ✅ 44.488MB (SLO: <47.000MB -5.3%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 316.618ms (SLO: <344.800ms -8.2%) vs baseline: -1.3% Memory: ✅ 594.989MB (SLO: <600.000MB 🟡 -0.8%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 288.917ms (SLO: <314.000ms -8.0%) vs baseline: +0.1% Memory: ✅ 597.037MB (SLO: <600.000MB 🟡 -0.5%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.695ms (SLO: <92.350ms 📉 -12.6%) vs baseline: -0.3% Memory: ✅ 39.966MB (SLO: <46.500MB 📉 -14.1%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 39.608ms (SLO: <44.500ms 📉 -11.0%) vs baseline: +1.2% Memory: ✅ 44.001MB (SLO: <47.500MB -7.4%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 58.772ms (SLO: <67.650ms 📉 -13.1%) vs baseline: -0.8% Memory: ✅ 40.308MB (SLO: <47.000MB 📉 -14.2%) vs baseline: +5.0% ✅ set-statusTime: ✅ 44.837ms (SLO: <50.400ms 📉 -11.0%) vs baseline: -0.2% Memory: ✅ 43.981MB (SLO: <47.000MB -6.4%) vs baseline: +4.8% ✅ startTime: ✅ 38.442ms (SLO: <43.450ms 📉 -11.5%) vs baseline: +0.8% Memory: ✅ 44.055MB (SLO: <47.000MB -6.3%) vs baseline: +5.0% ✅ start-finishTime: ✅ 82.871ms (SLO: <88.000ms -5.8%) vs baseline: +0.3% Memory: ✅ 34.623MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.190ms (SLO: <89.000ms -5.4%) vs baseline: +0.2% Memory: ✅ 34.623MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +5.0% ✅ update-nameTime: ✅ 40.275ms (SLO: <45.150ms 📉 -10.8%) vs baseline: -0.3% Memory: ✅ 44.295MB (SLO: <47.000MB -5.8%) vs baseline: +4.8% 🟡 span - 26/26✅ add-eventTime: ✅ 20.620ms (SLO: <22.500ms -8.4%) vs baseline: -0.7% Memory: ✅ 50.250MB (SLO: <53.000MB -5.2%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 90.065ms (SLO: <93.500ms -3.7%) vs baseline: -0.3% Memory: ✅ 661.213MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 148.155ms (SLO: <155.000ms -4.4%) vs baseline: +0.3% Memory: ✅ 661.593MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.9% ✅ get-contextTime: ✅ 19.041ms (SLO: <20.500ms -7.1%) vs baseline: -0.4% Memory: ✅ 49.100MB (SLO: <53.000MB -7.4%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 19.389ms (SLO: <20.500ms -5.4%) vs baseline: -0.4% Memory: ✅ 49.089MB (SLO: <53.000MB -7.4%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.434ms (SLO: <40.000ms -3.9%) vs baseline: +0.4% Memory: ✅ 42.652MB (SLO: <53.000MB 📉 -19.5%) vs baseline: +4.7% ✅ set-statusTime: ✅ 21.112ms (SLO: <22.000ms -4.0%) vs baseline: ~same Memory: ✅ 49.089MB (SLO: <53.000MB -7.4%) vs baseline: +4.7% ✅ startTime: ✅ 19.222ms (SLO: <20.500ms -6.2%) vs baseline: -0.4% Memory: ✅ 49.044MB (SLO: <53.000MB -7.5%) vs baseline: +4.7% ✅ start-finishTime: ✅ 51.598ms (SLO: <52.500ms 🟡 -1.7%) vs baseline: +0.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 52.839ms (SLO: <54.500ms -3.0%) vs baseline: -0.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +5.1% ✅ start-finish-traceid128Time: ✅ 55.421ms (SLO: <57.000ms -2.8%) vs baseline: +1.0% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 19.663ms (SLO: <22.500ms 📉 -12.6%) vs baseline: -0.4% Memory: ✅ 49.088MB (SLO: <53.000MB -7.4%) vs baseline: +4.8% ✅ update-nameTime: ✅ 20.110ms (SLO: <22.000ms -8.6%) vs baseline: ~same Memory: ✅ 49.690MB (SLO: <53.000MB -6.2%) vs baseline: +4.8%
|
a416989 to
207e227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to me to be critical enough to warrant a backport
|
@emmettbutler: without this PR, you may have to modify your ray job. Otherwise, ray jobs will crash when you submit your job when tracing is enabled (sometimes by default). For the other backports, I agree so I closed them. |
Backport 0b92c07 from #15087 to 3.16.
Without an explicit
ray.init()call at the beginning of the file, the ray job would fail because theray_trace_ctxwas not injected at the right moment.This PR fixes that